generated from unity-sds/unity-repo-template
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create health dashboard and integrate dynamic navbar #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…low us to use the latest stable release for builds as they are published without having to increment the version.
…bilities found using npm audit.
…ds/unity-ui into features/create-health-dashboard # Conflicts: # src/components/Navbar/index.tsx
…tion includes the protocol.
…nces by reorganizing CSS assets.
…N could be dynamically added to the navbar.
anilnatha
changed the title
Features/create health dashboard
Create health dashboard and integrate dynamic navbar
May 16, 2024
@rtapella The build checks are failing for the docker image build, I'll look into those and commit the fixes to this same branch. |
rtapella
approved these changes
May 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approve this in principle
once the build checks are passing it will be okay
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR addresses the addition of a health dashboard and addition of routes loaded through the health JSON to the navbar.
Note: Additional changes will be needed to address the need to sort the navbar and handle the routing of internal UIs (e.g. job monitoring, creating new jobs, health dashboard, etc.) vs externally hosted UIs (dockstore, stac browser, airflow, etc.) that are dynamically loaded via the health JSON data.
Proposed Changes
Issues
Testing
Health Dashboard
Updated Menu (Desktop)
Updated Menu (Mobile)