Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create health dashboard and integrate dynamic navbar #32

Merged
merged 18 commits into from
May 20, 2024

Conversation

anilnatha
Copy link
Collaborator

@anilnatha anilnatha commented May 16, 2024

Purpose

This PR addresses the addition of a health dashboard and addition of routes loaded through the health JSON to the navbar.

Note: Additional changes will be needed to address the need to sort the navbar and handle the routing of internal UIs (e.g. job monitoring, creating new jobs, health dashboard, etc.) vs externally hosted UIs (dockstore, stac browser, airflow, etc.) that are dynamically loaded via the health JSON data.

Proposed Changes

  • [ADD] Health Dashboard...
  • [CHANGE] Navbar to include routes added from the placeholder health JSON...
  • [FIX] Organization of CSS files...

Issues

Testing

  • Tested locally (See Screenshots)

Health Dashboard

image

Updated Menu (Desktop)

image

Updated Menu (Mobile)

image

…low us to use the latest stable release for builds as they are published without having to increment the version.
…ds/unity-ui into features/create-health-dashboard

# Conflicts:
#	src/components/Navbar/index.tsx
@anilnatha anilnatha requested a review from rtapella May 16, 2024 23:46
@anilnatha anilnatha changed the title Features/create health dashboard Create health dashboard and integrate dynamic navbar May 16, 2024
@anilnatha anilnatha marked this pull request as draft May 16, 2024 23:51
@anilnatha anilnatha changed the base branch from main to develop May 16, 2024 23:51
@anilnatha anilnatha marked this pull request as ready for review May 16, 2024 23:51
@anilnatha
Copy link
Collaborator Author

@rtapella The build checks are failing for the docker image build, I'll look into those and commit the fixes to this same branch.

Copy link
Contributor

@rtapella rtapella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve this in principle
once the build checks are passing it will be okay

@anilnatha anilnatha merged commit a1f1659 into develop May 20, 2024
1 check passed
@anilnatha anilnatha deleted the features/create-health-dashboard branch May 20, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants